Commit Graph

1477 Commits

Author SHA1 Message Date
Suren Baghdasaryan f6735b0b3a lmkd/tests: do not fail when occasionally reaping time is reported as 0 am: 90c4e26b9f am: 770c130e07 am: 361e23c48a am: c405cc646e
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2776306

Change-Id: Ie37d171ef62afe4c93a24b70b0b9aa3d05dd4da8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 01:18:15 +00:00
Suren Baghdasaryan c405cc646e lmkd/tests: do not fail when occasionally reaping time is reported as 0 am: 90c4e26b9f am: 770c130e07 am: 361e23c48a
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2776306

Change-Id: I1b9743ce2485d7ea38f1df68b3bbb812d41b2010
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 00:48:17 +00:00
Suren Baghdasaryan 361e23c48a lmkd/tests: do not fail when occasionally reaping time is reported as 0 am: 90c4e26b9f am: 770c130e07
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2776306

Change-Id: If884f01d61f86b8f3427b80d96ac01c16a993606
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 00:15:10 +00:00
Suren Baghdasaryan 770c130e07 lmkd/tests: do not fail when occasionally reaping time is reported as 0 am: 90c4e26b9f
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2776306

Change-Id: I063e7b3a7dd3829bb5219133e689af89522cd685
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 23:41:36 +00:00
Suren Baghdasaryan 90c4e26b9f lmkd/tests: do not fail when occasionally reaping time is reported as 0
In rare cases the process reaping time is short enough that it is
reported as 0. Prevent the test from failing in this rare case.

Bug: 296555636
Change-Id: I8484958eb9561ba345008195be8b6a7bd94e9ef3
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
2023-10-05 21:34:38 +00:00
Suren Baghdasaryan ae2331fec1 lmkd: Change critical thrashing limit to 3x of normal one am: ab906fb0ce am: 6c4dbbadb4 am: 74cb48967d am: a04ad4db3b
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2775527

Change-Id: Icf2e55be409018c1579db2de0aede4e10ac4ec85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:22:51 +00:00
Suren Baghdasaryan a04ad4db3b lmkd: Change critical thrashing limit to 3x of normal one am: ab906fb0ce am: 6c4dbbadb4 am: 74cb48967d
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2775527

Change-Id: Ib90190894f36a5af173a7a307903327d8dcbb562
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 18:47:06 +00:00
Suren Baghdasaryan 74cb48967d lmkd: Change critical thrashing limit to 3x of normal one am: ab906fb0ce am: 6c4dbbadb4
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2775527

Change-Id: I70b56cf4e700ca1120e896a49e6e875172b0a358
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 18:15:27 +00:00
Suren Baghdasaryan 6c4dbbadb4 lmkd: Change critical thrashing limit to 3x of normal one am: ab906fb0ce
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2775527

Change-Id: Ib323320285b841a452675b33cee8634bafc9157f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 17:44:57 +00:00
Suren Baghdasaryan ab906fb0ce lmkd: Change critical thrashing limit to 3x of normal one
As a result of experiments, the default relation between critical and
normal thrashing limits has been shown to be insufficient. Increase the
relation from 2x to 3x.

Bug: 194316048
Change-Id: I19877e0df56be07f3f503688f408f5f91f4b1e67
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
2023-10-05 15:07:04 +00:00
Kalesh Singh 5164031220 Merge "lmkd: Remove uses of hardcoded 4k PAGE_SIZE macro" into main am: f6f744fcc9 am: 8649898f6c am: 6aff556a55 am: 9add92ee7f
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2694569

Change-Id: I95d86740b48e0108cfe5a9a296e66c4b26ce993f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 03:09:15 +00:00
Kalesh Singh 9add92ee7f Merge "lmkd: Remove uses of hardcoded 4k PAGE_SIZE macro" into main am: f6f744fcc9 am: 8649898f6c am: 6aff556a55
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2694569

Change-Id: I9bf47902e27ea862e889fd3b573792f059f06d3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 02:23:43 +00:00
Kalesh Singh 6aff556a55 Merge "lmkd: Remove uses of hardcoded 4k PAGE_SIZE macro" into main am: f6f744fcc9 am: 8649898f6c
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2694569

Change-Id: I2734319fba60b770cd7cab5bb2013cd125d219e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 01:40:06 +00:00
Kalesh Singh 8649898f6c Merge "lmkd: Remove uses of hardcoded 4k PAGE_SIZE macro" into main am: f6f744fcc9
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2694569

Change-Id: I5207e77969fed083af7a7907fa1014ff0853ce95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 00:56:30 +00:00
Kalesh Singh f6f744fcc9 Merge "lmkd: Remove uses of hardcoded 4k PAGE_SIZE macro" into main 2023-08-09 00:18:34 +00:00
Kalesh Singh 5d397582ac lmkd: Remove uses of hardcoded 4k PAGE_SIZE macro
Use getpagesize() to query the real page size instead.

Bug: 294618124
Test: m
Change-Id: If9046f36412a54ba08b94cf3b43cd7bf9c1f26b5
2023-08-08 15:58:16 -07:00
Suren Baghdasaryan 844fa71bc7 lmkd: check pgrefill vmstat when deciding active reclaim am: 4d8791b1f1 am: 3d9c7f86fa am: d194d9188f am: 17c4843c31
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2662996

Change-Id: I64155b8e4e4647973f86e1ae0f909b211587a99c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-29 01:19:58 +00:00
Suren Baghdasaryan 17c4843c31 lmkd: check pgrefill vmstat when deciding active reclaim am: 4d8791b1f1 am: 3d9c7f86fa am: d194d9188f
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2662996

Change-Id: I8a4cab96fb4b2890ce539ac0e62eccc73ef55516
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-29 00:18:11 +00:00
Suren Baghdasaryan d194d9188f lmkd: check pgrefill vmstat when deciding active reclaim am: 4d8791b1f1 am: 3d9c7f86fa
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2662996

Change-Id: I38db2a8a9740d541ee92b3ae40ad186ffd8dc6d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-28 23:31:54 +00:00
Suren Baghdasaryan 3d9c7f86fa lmkd: check pgrefill vmstat when deciding active reclaim am: 4d8791b1f1
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2662996

Change-Id: I4b7e1a8bc1f8d5c706ff8fbdfbba952309cf643b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-28 22:52:14 +00:00
Suren Baghdasaryan 4d8791b1f1 lmkd: check pgrefill vmstat when deciding active reclaim
In rare cases it's possible that pgscan is not changing because inactive
LRU is empty and can't be refilled from the active LRU due to all
pages being hot. In such conditions pgscan_kswapd/pgscan_direct will
not change while pgrefill will be increasing due to active LRU being
scanned. Lmkd would incorrectly treat this situation as if no reclaim
activity happened.
Change lmkd to check pgrefill as well to detect such conditions.

Bug: 288383787
Change-Id: I6b49607429e2f673bba2645ccddff1a141afbcd1
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
2023-07-28 20:48:15 +00:00
Lee George Thomas 7a68ef4995 [automerger skipped] Add a configuration to delay monitor initialization am: 1847e9d7ab am: f53e58ae1d -s ours am: 3f840a5a9f -s ours am: 70ea9aa15e -s ours
am skip reason: Merged-In I17cfbf4c7f83bc80dd92a99dfb0254a7e20289be with SHA-1 d0a45850e7 is already in history

Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2650042

Change-Id: I19e5619a91718668f648a53d35415cc9b58e50ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 00:23:04 +00:00
Lee George Thomas 70ea9aa15e [automerger skipped] Add a configuration to delay monitor initialization am: 1847e9d7ab am: f53e58ae1d -s ours am: 3f840a5a9f -s ours
am skip reason: Merged-In I17cfbf4c7f83bc80dd92a99dfb0254a7e20289be with SHA-1 d0a45850e7 is already in history

Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2650042

Change-Id: I2a7d4db42053317ecda507cd64f2ca6fd2799781
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 23:59:10 +00:00
Lee George Thomas 3f840a5a9f [automerger skipped] Add a configuration to delay monitor initialization am: 1847e9d7ab am: f53e58ae1d -s ours
am skip reason: Merged-In I17cfbf4c7f83bc80dd92a99dfb0254a7e20289be with SHA-1 d0a45850e7 is already in history

Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2650042

Change-Id: I86580a53b8781b02dcaa5a034f5b9eb102cb683e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 23:36:47 +00:00
Lee George Thomas f53e58ae1d Add a configuration to delay monitor initialization am: 1847e9d7ab
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2650042

Change-Id: I6deffbc47fa0a6b7322cf35e41692a1ce0048c4c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 22:57:50 +00:00
Lee George Thomas 7b1df14f6b Add a configuration to delay monitor initialization am: d0a45850e7 am: 2f0a1bdf1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/memory/lmkd/+/24009226

Change-Id: I5585634e5f173b48743a7ace33dd68a1f9220a49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 21:01:11 +00:00
Lee George Thomas 2f0a1bdf1a Add a configuration to delay monitor initialization am: d0a45850e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/memory/lmkd/+/24009226

Change-Id: I640c5585a01a1e104c0222cf85ab46662a71f9f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 20:16:55 +00:00
Lee George Thomas 1847e9d7ab Add a configuration to delay monitor initialization
To save CPU cycles during boot for low resource device a new
configuration is added to delay initialization of monitoring until boot
is complete.

Bug: 288566858
Test: Build, boot and verified boot logs to confirm the behavior.
Merged-In: I17cfbf4c7f83bc80dd92a99dfb0254a7e20289be

Change-Id: I17cfbf4c7f83bc80dd92a99dfb0254a7e20289be
2023-07-19 19:46:12 +00:00
Lee George Thomas d0a45850e7 Add a configuration to delay monitor initialization
To save CPU cycles during boot for low resource device a new
configuration is added to delay initialization of monitoring until boot
is complete.

Bug: 288566858
Test: Build, boot and verified boot logs to confirm the behavior.

Change-Id: I17cfbf4c7f83bc80dd92a99dfb0254a7e20289be
2023-07-18 17:45:17 -07:00
Suren Baghdasaryan bae2dfebb6 lmkd: remove unused LMK_STAT_STATE_CHANGED notification am: 5860e852f8 am: 9260f6fdf4 am: 9c57dad3d2 am: b77b392278 am: feaf9bbc0f
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2596772

Change-Id: I26f57abd01695f83fc358af1ef9c8f733450b933
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 04:51:03 +00:00
Suren Baghdasaryan feaf9bbc0f lmkd: remove unused LMK_STAT_STATE_CHANGED notification am: 5860e852f8 am: 9260f6fdf4 am: 9c57dad3d2 am: b77b392278
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2596772

Change-Id: Ibc183ce960a4615a7975aa428018c9eeda1bcfb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 04:01:30 +00:00
Suren Baghdasaryan b77b392278 lmkd: remove unused LMK_STAT_STATE_CHANGED notification am: 5860e852f8 am: 9260f6fdf4 am: 9c57dad3d2
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2596772

Change-Id: Iac383521d66b64009eae4ca731b5950a191e33d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 03:10:13 +00:00
Suren Baghdasaryan 9c57dad3d2 lmkd: remove unused LMK_STAT_STATE_CHANGED notification am: 5860e852f8 am: 9260f6fdf4
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2596772

Change-Id: I9e6505aec49e190960395448cc201e22229e87ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 02:22:46 +00:00
Suren Baghdasaryan 9260f6fdf4 lmkd: remove unused LMK_STAT_STATE_CHANGED notification am: 5860e852f8
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2596772

Change-Id: Ie9de6d0d3f35ab4e12ab63b01fe5838fecf55099
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 01:34:24 +00:00
Suren Baghdasaryan 5860e852f8 lmkd: remove unused LMK_STAT_STATE_CHANGED notification
The LmkStateChanged atom was historically used to mark lmk activity
and trigger additional stats polling. For more than a year this has
not been used at all (as statsd supported event-based triggering).
Remove unnecessary functionality.

Bug: 278174420
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I9f7f56711fabb751cf7a57ea7279759bcc4a3dff
2023-05-19 14:08:10 -07:00
Kameron Lutes 499cc71e28 lmkd: Send Actual OOM Score to lmkd_free_memory_before_kill_hook am: 556740ef04 am: 52d4c9c66d am: 4fb4ad2282 am: f935f02145
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2489435

Change-Id: I1c09b7eec278845f417f8d0c007c1ea05b2a2478
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 04:26:56 +00:00
Kameron Lutes f935f02145 lmkd: Send Actual OOM Score to lmkd_free_memory_before_kill_hook am: 556740ef04 am: 52d4c9c66d am: 4fb4ad2282
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2489435

Change-Id: Ia0d934ba44f0ec835ada7853836bd939f4980a9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 03:46:28 +00:00
Mateus Azis 85b2f08419 Improve code formatting for lmkd's README. am: bb87e41b6f am: 5bc7c509d5 am: ada49845b0 am: 6dc1b3f913
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2497556

Change-Id: Id13822442b616871b4550f70fd4ebf24343f67ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 03:08:58 +00:00
Kameron Lutes 4fb4ad2282 lmkd: Send Actual OOM Score to lmkd_free_memory_before_kill_hook am: 556740ef04 am: 52d4c9c66d
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2489435

Change-Id: I290c75ace14c6b386f4bb546e6de00bb46bf7831
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 02:48:47 +00:00
Mateus Azis 6dc1b3f913 Improve code formatting for lmkd's README. am: bb87e41b6f am: 5bc7c509d5 am: ada49845b0
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2497556

Change-Id: If7419f3eaddee1da55a092663ef210ccd04a262d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 02:17:41 +00:00
Kameron Lutes 52d4c9c66d lmkd: Send Actual OOM Score to lmkd_free_memory_before_kill_hook am: 556740ef04
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2489435

Change-Id: I7f97cd8c982de680fc3d2e7e8c7e9d8ef1bfe125
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 02:12:09 +00:00
Mateus Azis ada49845b0 Improve code formatting for lmkd's README. am: bb87e41b6f am: 5bc7c509d5
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2497556

Change-Id: I8f57373b0dd8a50cb4e916318bdb2dcb7998fa3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 01:33:17 +00:00
Mateus Azis 5bc7c509d5 Improve code formatting for lmkd's README. am: bb87e41b6f
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2497556

Change-Id: Ica7d6432333f5c40ec4caab690862e20d84039a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 01:05:44 +00:00
Kameron Lutes 556740ef04 lmkd: Send Actual OOM Score to lmkd_free_memory_before_kill_hook
Previously the min_oom score of the candidate search was sent to
lmkd_free_memory_before_kill_hook. This is incorrect as the hook expects
the actual oom score of the process.

Bug: b/273670531
Test: cq
Change-Id: Id72c8b39f9c745a8f20fde15266857cb2d2222bf
2023-03-22 00:33:30 +00:00
Mateus Azis bb87e41b6f Improve code formatting for lmkd's README.
Before: https://android.googlesource.com/platform/system/memory/lmkd/+/refs/heads/master/README.md
After: https://android.googlesource.com/platform/system/memory/lmkd/+/refs/changes/56/2497556/2/README.md

Test: N/A
Change-Id: Id7fa7d0ffb66590525a978e3ee716ee567ea9fd6
2023-03-20 09:38:06 -07:00
Julien Desprez 0147eded26 Move lmkd_tests to 'presubmit' group am: bedcba1885 am: 6d6feea2da am: 7e055d03a2 am: 6d1d0f0aac
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2464654

Change-Id: Id94404c2dfe6a76846edb72a7ce998c362d43f7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 03:14:40 +00:00
Julien Desprez 6d1d0f0aac Move lmkd_tests to 'presubmit' group am: bedcba1885 am: 6d6feea2da am: 7e055d03a2
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2464654

Change-Id: I44c718953a26a88e1415a926f0a66d17ac4b534c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 02:36:55 +00:00
Julien Desprez 7e055d03a2 Move lmkd_tests to 'presubmit' group am: bedcba1885 am: 6d6feea2da
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2464654

Change-Id: I09a89a769e68774428bbe75c7c01f4cf949be70d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 01:59:09 +00:00
Julien Desprez 6d6feea2da Move lmkd_tests to 'presubmit' group am: bedcba1885
Original change: https://android-review.googlesource.com/c/platform/system/memory/lmkd/+/2464654

Change-Id: Ie95b86af73903df43f39eb22cbd5856662d969ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 01:06:38 +00:00
Julien Desprez bedcba1885 Move lmkd_tests to 'presubmit' group
Doesn't need to be in 'presubmit-large' as it's a small and quick test.

Change-Id: I7a6b78cf3174993361f50d8d7adfdf86c9d20e28
Test: presubmit
Bug: 270214959
2023-03-01 21:42:30 +00:00