From b9d0592bba767cc65885465dc7b9cb254a18ef2d Mon Sep 17 00:00:00 2001 From: Ioannis Ilkos Date: Thu, 4 Aug 2022 14:45:24 +0100 Subject: [PATCH] Remove kill_one_process tracepoint from lmkd We already emit a richer slice (including pid and oom score) so there's no reason for the additional print event Bug: 195085238 Change-Id: I1140f0287934e5f0abdeeb64554a249c4c940def --- lmkd.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lmkd.cpp b/lmkd.cpp index 0f54f34..616b07b 100644 --- a/lmkd.cpp +++ b/lmkd.cpp @@ -66,19 +66,17 @@ #define ATRACE_TAG ATRACE_TAG_ALWAYS #include -static inline void trace_kill_start(int pid, const char *desc) { - ATRACE_INT("kill_one_process", pid); +static inline void trace_kill_start(const char *desc) { ATRACE_BEGIN(desc); } static inline void trace_kill_end() { ATRACE_END(); - ATRACE_INT("kill_one_process", 0); } #else /* LMKD_TRACE_KILLS */ -static inline void trace_kill_start(int, const char *) {} +static inline void trace_kill_start(const char *) {} static inline void trace_kill_end() {} #endif /* LMKD_TRACE_KILLS */ @@ -2337,7 +2335,7 @@ static int kill_one_process(struct proc* procp, int min_oom_score, struct kill_i return result; } - trace_kill_start(pid, desc); + trace_kill_start(desc); start_wait_for_proc_kill(pidfd < 0 ? pid : pidfd); kill_result = reaper.kill({ pidfd, pid, uid }, false);